[Merged by Bors] - Fix incorrect LoopContinue instruction in while-do loops
#2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Test262 conformance changes
|
3 tasks
HalidOdat
requested review from
Razican,
jasonwilliams,
RageKnify,
raskad,
jedel1043 and
nekevss
Codecov Report
@@ Coverage Diff @@
## main #2866 +/- ##
=======================================
Coverage 50.95% 50.95%
=======================================
Files 419 419
Lines 41874 41874
=======================================
Hits 21335 21335
Misses 20539 20539
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
approved these changes
Apr 24, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
While working on #2857 I discovered that while generating the bytecode for `do-while` loops we were emitting an orphan `LoopContinue` that is never executed, which was preventing the error to be thrown when max loop iteration is reached. This can more easily be identified with it's flowgraph : (`do { 1; } while(0) `) Main: <details> <img src="https://user-images.githubusercontent.com/8566042/233908011-247313bc-6435-4622-8ecb-f469d9eaf850.png"> </details> With this PR: <details> <img src="https://user-images.githubusercontent.com/8566042/233908030-3552636e-f09c-4c5e-8c7c-1ecfa0024dfe.png"> </details>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
LoopContinue instruction in while-do loopsLoopContinue instruction in while-do loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2857 I discovered that while generating the bytecode for
do-whileloops we were emitting an orphanLoopContinuethat is never executed, which was preventing the error to be thrown when max loop iteration is reached.This can more easily be identified with it's flowgraph : (
do { 1; } while(0))Main:
With this PR: